Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12896#discussion_r62890352
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -71,6 +71,26 @@ private[recommendation] trait ALSModelParams extends
Params with HasPredictionCo
/** @group getParam */
def getItemCol: String = $(itemCol)
+
+ /**
+ * Param for strategy for dealing with unknown or new users/items at
prediction time.
+ * This may be useful in cross-validation or production scenarios, for
handling user/item ids
+ * the model has not seen in the training data.
+ * Supported values:
+ * - "nan": predicted value for unknown ids will be NaN.
--- End diff --
Nope - easier to type? :) also seems consistent with most other string
params which seem to be lower case (eg "rmse", "map" etc).
On Wed, 11 May 2016 at 19:24, Holden Karau <[email protected]> wrote:
> In mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
> <https://github.com/apache/spark/pull/12896#discussion_r62889428>:
>
> > @@ -71,6 +71,26 @@ private[recommendation] trait ALSModelParams extends
Params with HasPredictionCo
> >
> > /** @group getParam */
> > def getItemCol: String = $(itemCol)
> > +
> > + /**
> > + * Param for strategy for dealing with unknown or new users/items at
prediction time.
> > + * This may be useful in cross-validation or production scenarios,
for handling user/item ids
> > + * the model has not seen in the training data.
> > + * Supported values:
> > + * - "nan": predicted value for unknown ids will be NaN.
>
> Any reason why "nan" rather than "NaN"?
>
> â
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub
>
<https://github.com/apache/spark/pull/12896/files/b71dcaca39d5f10b484932eaf25e290c7796d93b#r62889428>
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
