Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12719#issuecomment-218560535
Hi, @cloud-fan . Now, it passed again.
For the remaining comments, I can do that but the reason is not clear to me.
> I prefer to handle one Project each round, which is easier to add more
optimizations. e.g. after FoldablePropagation, we should be able to remove the
foldable expressions in project list.
- What do you mean by `easy to add more optimization`? Do you mean `it's
easy to modify FoldablePropagation` later?
- Why should we remove the foldable expressions from project list? Do you
mean ORDER BY or GROUP BY?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
