Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1707#discussion_r15770021
--- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala ---
@@ -67,9 +67,8 @@ class SparkEnv (
val metricsSystem: MetricsSystem,
val conf: SparkConf) extends Logging {
- // A mapping of thread ID to amount of memory, in bytes, used for
shuffle aggregations
- // All accesses should be manually synchronized
- val shuffleMemoryMap = mutable.HashMap[Long, Long]()
+ // Manages the memory used by externally spilling collections in shuffle
operations
+ val shuffleMemoryManager = new ShuffleMemoryManager(conf)
--- End diff --
Do we want to add this to the constructor, like we do for other `*Managers`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
