Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/13061#issuecomment-218614273
Hi @dhruve,
This is going in the right direction; this looks a lot more manageable than
the previous plugin-based approach. I have a couple of request though:
- Instead of embedding the shell code in the maven and sbt builds, could
you actually write a shell script and execute it from both places? Then the
code is shared, easier to read and debug, all that good stuff.
- I don't really like code that pollutes the source directory; you should
instead generate the properties file in the build directory. That should be
done in the `generate-resources` phase of the maven build, and I think the
easiest way is to write the file to `${project.build.directory}/classes`
directly.
For the sbt build you probably would have to hook something up to
`resourceGenerators`; there are a couple of examples of using that in the build
file, you could start from those.
I might be wrong, but I don't believe the generated file needs a copyright
header.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
