Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13079#discussion_r63108072
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala 
---
    @@ -338,6 +338,14 @@ private[hive] class HiveClientImpl(
           // partition columns are part of the schema
           val partCols = h.getPartCols.asScala.map(fromHiveColumn)
           val schema = h.getCols.asScala.map(fromHiveColumn) ++ partCols
    +
    +      // Skew spec, storage handler, and bucketing info can't be mapped to 
CatalogTable (yet)
    +      val fullyMapped = (
    +        h.getSkewedColNames.isEmpty
    +          && h.getStorageHandler == null
    +          && h.getBucketCols.isEmpty
    +      )
    --- End diff --
    
    nit: can you use `{ }` here instead? We usually don't use `( )` for things 
like these


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to