Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/12921#discussion_r63140449
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVTypeCastSuite.scala
---
@@ -73,10 +73,10 @@ class CSVTypeCastSuite extends SparkFunSuite {
test("String type should always return the same as the input") {
assert(
- CSVTypeCast.castTo("", StringType, nullable = true, CSVOptions()) ==
+ CSVTypeCast.castTo("", StringType, nullable = true,
CSVOptions("nullValue", null)) ==
UTF8String.fromString(""))
assert(
- CSVTypeCast.castTo("", StringType, nullable = false, CSVOptions()) ==
+ CSVTypeCast.castTo("", StringType, nullable = false,
CSVOptions("nullValue", null)) ==
--- End diff --
Otherwise, `null`s for `StringType` will be lost in the roundtrip of
reading and writing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
