GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/13126
[SPARK-14603] [SQL] [FOLLOWUP] Verification of Metadata Operations by
Session Catalog
#### What changes were proposed in this pull request?
This follow-up PR is to address the comments in
https://github.com/apache/spark/pull/12385
The major change in this PR is to issue better error message in PySpark by
using the mechanism that was proposed by @davies in
https://github.com/apache/spark/pull/7135
For example, in PySpark, if we input the following statement:
```python
>>> l = [('Alice', 1)]
>>> df = sqlContext.createDataFrame(l)
>>> df.createTempView("people")
>>> df.createTempView("people")
```
Before this PR, the exception we will get is like
```
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File
"/Users/xiaoli/IdeaProjects/sparkDelivery/python/pyspark/sql/dataframe.py",
line 152, in createTempView
self._jdf.createTempView(name)
File
"/Users/xiaoli/IdeaProjects/sparkDelivery/python/lib/py4j-0.10.1-src.zip/py4j/java_gateway.py",
line 933, in __call__
File
"/Users/xiaoli/IdeaProjects/sparkDelivery/python/pyspark/sql/utils.py", line
63, in deco
return f(*a, **kw)
File
"/Users/xiaoli/IdeaProjects/sparkDelivery/python/lib/py4j-0.10.1-src.zip/py4j/protocol.py",
line 312, in get_return_value
py4j.protocol.Py4JJavaError: An error occurred while calling
o35.createTempView.
: org.apache.spark.sql.catalyst.analysis.TempTableAlreadyExistsException:
Temporary table 'people' already exists;
at
org.apache.spark.sql.catalyst.catalog.SessionCatalog.createTempView(SessionCatalog.scala:324)
at
org.apache.spark.sql.SparkSession.createTempView(SparkSession.scala:523)
at org.apache.spark.sql.Dataset.createTempView(Dataset.scala:2328)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at py4j.reflection.MethodInvoker.invoke(MethodInvoker.java:237)
at py4j.reflection.ReflectionEngine.invoke(ReflectionEngine.java:357)
at py4j.Gateway.invoke(Gateway.java:280)
at py4j.commands.AbstractCommand.invokeMethod(AbstractCommand.java:128)
at py4j.commands.CallCommand.execute(CallCommand.java:79)
at py4j.GatewayConnection.run(GatewayConnection.java:211)
at java.lang.Thread.run(Thread.java:745)
```
After this PR, the exception we will get become cleaner:
```
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File
"/Users/xiaoli/IdeaProjects/sparkDelivery/python/pyspark/sql/dataframe.py",
line 152, in createTempView
self._jdf.createTempView(name)
File
"/Users/xiaoli/IdeaProjects/sparkDelivery/python/lib/py4j-0.10.1-src.zip/py4j/java_gateway.py",
line 933, in __call__
File
"/Users/xiaoli/IdeaProjects/sparkDelivery/python/pyspark/sql/utils.py", line
75, in deco
raise AnalysisException(s.split(': ', 1)[1], stackTrace)
pyspark.sql.utils.AnalysisException: u"Temporary table 'people' already
exists;"
```
#### How was this patch tested?
Fixed an existing PySpark test case
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gatorsmile/spark followup-14684
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13126.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13126
----
commit 4c65b6c4079869f043fa9272f6ad04e831e50b2f
Author: gatorsmile <[email protected]>
Date: 2016-05-15T21:21:24Z
fix
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
