Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13127#discussion_r63351076
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -130,109 +124,343 @@ class VersionsSuite extends SparkFunSuite with
Logging {
test(s"$version: create client") {
client = null
System.gc() // Hack to avoid SEGV on some JVM versions.
+ val hadoopConf = new Configuration();
+ hadoopConf.set("test", "success")
client =
IsolatedClientLoader.forVersion(
hiveMetastoreVersion = version,
hadoopVersion = VersionInfo.getVersion,
sparkConf = sparkConf,
- hadoopConf = new Configuration(),
+ hadoopConf,
config = buildConf(),
ivyPath = ivyPath).createClient()
}
+ def table(database: String, tableName: String): CatalogTable = {
+ CatalogTable(
+ identifier = TableIdentifier(tableName, Some(database)),
+ tableType = CatalogTableType.MANAGED,
+ schema = Seq(CatalogColumn("key", "int")),
+ storage = CatalogStorageFormat(
+ locationUri = None,
+ inputFormat =
Some(classOf[org.apache.hadoop.mapred.TextInputFormat].getName),
+ outputFormat = Some(
+
classOf[org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat[_,
_]].getName),
+ serde =
Some(classOf[org.apache.hadoop.hive.serde2.`lazy`.LazySimpleSerDe].getName()),
--- End diff --
How about import these Hive classes above instead of using the fully
qualified names here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
