Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13138#discussion_r63399671
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/RowEncoderSuite.scala
 ---
    @@ -185,6 +185,20 @@ class RowEncoderSuite extends SparkFunSuite {
         assert(encoder.serializer.head.nullable == false)
       }
     
    +  test("RowEncoder should support array as the external type for 
ArrayType") {
    --- End diff --
    
    This is fine for now, but should we build the equivalent of 
`encodeDecodeTest` for `Row`s? or is this the only special case?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to