Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/11996#discussion_r63447507
--- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala ---
@@ -71,11 +73,16 @@ class TaskInfo(
failed = true
}
+ private[spark] def markKilled(time: Long = System.currentTimeMillis) {
--- End diff --
Can you consolidate this and the two methods above into a single
markFinished method that accepts a TaskState and a time? And then that method
can handle matching the TaskState to the appropriate value of killed / failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]