Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13105#discussion_r63447722
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/DefaultSource.scala
 ---
    @@ -172,4 +173,15 @@ class DefaultSource extends FileFormat with 
DataSourceRegister {
             .mapPartitions(_.map(pair => new String(pair._2.getBytes, 0, 
pair._2.getLength, charset)))
         }
       }
    +
    +  private def verifySchema(schema: StructType): Unit = {
    +    schema.foreach {
    +      field => field.dataType match {
    --- End diff --
    
    Oh, I should have said this clearly. Here is a good documentation, 
(https://github.com/databricks/scala-style-guide#pattern-matching).
    
    I think
    
    ```scala
    schema.foreach { field =>
      field.dataType match { 
    ...
    ```
    would be nicer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to