Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13057#discussion_r63548281
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/ExecutorRunnable.scala ---
@@ -211,15 +211,15 @@ private[yarn] class ExecutorRunnable(
Seq("--user-class-path", "file:" + absPath)
}.toSeq
+ // Kill if OOM is raised - leverage yarn's failure handling to cause
rescheduling.
+ // Not killing the task leaves various aspects of the executor and (to
some extent) the jvm in
+ // an inconsistent state.
+ // TODO: If the OOM is not recoverable by rescheduling it on different
node, then do
+ // 'something' to fail job ... akin to blacklisting trackers in mapred
?
--- End diff --
Really this comment belongs with the method doc -- should have been there
before. You could move it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
