Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/12939#issuecomment-219944159
I have one concern about the whitelisting approach. Even if each single
character is safe, it's difficult to ensure any character sequences which
consist of those safe characters are always safe.
E.g. `*` and `/` are safe themselves but `*/` is not safe. It's difficult
to ensure there are no unsafe combination such.
The place holder approach I mentioned above (#12979) may be safer because
the place holder consists of only `{`, `comment_placeholder`, numbers and `}`.
Anyway, I'll try the whitelisting approach. Let's discuss more.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
