GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/13165
[SPARK-8603][SPARKR] Incorrect file separator passed to Java and Scripts
from R in windows
## What changes were proposed in this pull request?
This PR corrects R file separator to accept Windows.
According to the R API,
[file](https://stat.ethz.ch/R-manual/R-devel/library/base/html/file.path.html),
>```R
>file.path(..., fsep = .Platform$file.sep)
>```
`file.path` API takes `.Platform$file.sep` but the default value for this
is, `/` regardless of OS type.
Also, this is written as a note in the line as below:
>The components are by default separated by / (not \) on Windows.
## How was this patch tested?
Jenkins tests and manually tested in a Window machine as below:
```R
> .Platform$OS.type
[1] "windows"
```
```R
> .Platform$file.sep
[1] "/"
```
Closes #7025
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/spark pr/7025
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13165.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13165
----
commit 6f0f5aba39d7986b12f6413bd13296c3ca3538d9
Author: Prakash PC <prakash.chi...@gmail.com>
Date: 2015-06-25T18:29:38Z
[SPARK-8603] [sparkR] In windows, Incorrect file seperator passed to Java
and Scripts from R
commit 24e37e144c4b0c575c5f2a80a56cb56a70386c51
Author: hyukjinkwon <gurwls...@gmail.com>
Date: 2016-05-18T07:45:27Z
Fetch upstream
commit 454b7f53c1bf587325154535204695247c1b3d6a
Author: hyukjinkwon <gurwls...@gmail.com>
Date: 2016-05-18T07:52:51Z
Correct condition, fix style and comments
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
