Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13104#discussion_r63798411
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
    @@ -457,7 +457,8 @@ class DataFrameReader private[sql](sparkSession: 
SparkSession) extends Logging {
        */
       @scala.annotation.varargs
       def text(paths: String*): Dataset[String] = {
    -    format("text").load(paths : 
_*).as[String](sparkSession.implicits.newStringEncoder)
    +    format("text").load(paths : _*).select("value")
    --- End diff --
    
    Yeah, I think the semantic of dropping the columns is okay (I'm not sure 
the other option makes sense to me).  I'm a little concerned that we are still 
doing partition discovery, but I guess removing that is only an optimization.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to