GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/13185
[SPARK-15395][Core]Use getHostString to create RpcAddress
## What changes were proposed in this pull request?
Right now the netty RPC uses `InetSocketAddress.getHostName` to create
`RpcAddress` for network events. If we use an IP address to connect, then the
RpcAddress's host will be a host name (if the reverse lookup successes) instead
of the IP address. However, some places need to compare the original IP address
and the RpcAddress in `onDisconnect` (e.g., CoarseGrainedExecutorBackend), and
this behavior will make the check incorrect.
This PR uses `getHostString` to resolve the issue.
## How was this patch tested?
Jenkins unit tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zsxwing/spark host-string
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13185.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13185
----
commit be7ec5ffc140c59935479332698fef640626d8e2
Author: Shixiong Zhu <shixi...@databricks.com>
Date: 2016-05-19T00:03:20Z
Use getHostString to create RpcAddress
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
