Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/12719#issuecomment-220202352
If this is the only case, I prefer to remove this line:
`checkEvaluation(FormatNumber(Literal.create(null, NullType), Literal(3)),
null)`
In real world, analyzer will cast null type to any type the expression
needed, and I don't think null type worth testing here(expression unit test)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
