Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13045#discussion_r63809763
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
 ---
    @@ -326,9 +326,14 @@ case class UnresolvedExtractValue(child: Expression, 
extraction: Expression)
      *
      * @param child The computation that is needs to be resolved during 
analysis.
      * @param aliasName The name if specified to be associated with the result 
of computing [[child]]
    + * @param aliasFunc The function if specified to be called to generate an 
alias to associate
    + *                  with the result of computing [[child]]
      *
      */
    -case class UnresolvedAlias(child: Expression, aliasName: Option[String] = 
None)
    +case class UnresolvedAlias(
    +    child: Expression,
    +    aliasName: Option[String] = None,
    +    aliasFunc: Option[Expression => String] = None)
    --- End diff --
    
    I think `aliasFunc` is enough. Ideally `aliasName` is also a function that 
ignore the parameter and return a string.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to