Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/13182#discussion_r63810701
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala
---
@@ -72,9 +72,18 @@ case class BroadcastExchangeExec(
val beforeCollect = System.nanoTime()
// Note that we use .executeCollect() because we don't want to
convert data to Scala types
val input: Array[InternalRow] = child.executeCollect()
+ if (input.length >= (512 << 20)) {
+ throw new SparkException(
+ s"Cannot broadcast the table with more than 512 millions rows:
${input.length} rows")
--- End diff --
I think it'd be good to make these 2 consistent (either use 512 << 20 or
512000000 at both places)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
