Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/12951#discussion_r63911572
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SchedulableBuilder.scala ---
@@ -90,10 +92,16 @@ private[spark] class FairSchedulableBuilder(val
rootPool: Pool, conf: SparkConf)
private def buildDefaultPool() {
if (rootPool.getSchedulableByName(DEFAULT_POOL_NAME) == null) {
val pool = new Pool(DEFAULT_POOL_NAME, DEFAULT_SCHEDULING_MODE,
- DEFAULT_MINIMUM_SHARE, DEFAULT_WEIGHT)
+ DEFAULT_MINIMUM_SHARE, DEFAULT_MAXIMUM_SHARE, DEFAULT_WEIGHT)
rootPool.addSchedulable(pool)
- logInfo("Created default pool %s, schedulingMode: %s, minShare: %d,
weight: %d".format(
- DEFAULT_POOL_NAME, DEFAULT_SCHEDULING_MODE, DEFAULT_MINIMUM_SHARE,
DEFAULT_WEIGHT))
+ logInfo(
--- End diff --
as long as you're touching this, switch to using string interpolation.
(eg. `s"Created default pool $DEFAULT_POOL_NAME, ...`). Also since this is
repeated a few times, you might just add a helper `logPoolCreated(pool)` or
something.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
