Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/1761#issuecomment-51177555
@JoshRosen As in all things you probably have to weight benefits vs costs?
A hypothetical merge conflict might be an important or trivial worry depending
on where it is. Some small changes do improve readability or performance, some
are just trivial. I'd rather not declare that existing code can only take clear
bug fixes. This looks trivial and may even not even match the intended use of
the method, so yeah. I'm actually more concerned than anything about the
overhead of processing a hundred tiny PRs. So there's a burden of proof that
it's worth your time and the merge conflict.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
