Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13209#discussion_r63984257
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -178,7 +178,12 @@ private[sql] abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
// Pick CartesianProduct for InnerJoin
case logical.Join(left, right, Inner, condition) =>
- joins.CartesianProductExec(planLater(left), planLater(right),
condition) :: Nil
+ if (conf.cartesianProductEnabled) {
+ joins.CartesianProductExec(planLater(left), planLater(right),
condition) :: Nil
+ } else {
+ throw new AnalysisException("Cartesian products are disabled by
default. To explicitly " +
+ "enable them, please set spark.sql.join.cartesian.enabled =
true")
--- End diff --
better use the key itself rather than hard coding it here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
