Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1218#discussion_r15828506
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1531,18 +1532,6 @@ object SparkContext extends Logging {
throw new SparkException("YARN mode not available ?", e)
}
}
- val backend = try {
- val clazz =
-
Class.forName("org.apache.spark.scheduler.cluster.YarnClusterSchedulerBackend")
- val cons = clazz.getConstructor(classOf[TaskSchedulerImpl],
classOf[SparkContext])
- cons.newInstance(scheduler,
sc).asInstanceOf[CoarseGrainedSchedulerBackend]
- } catch {
- case e: Exception => {
- throw new SparkException("YARN mode not available ?", e)
- }
- }
- scheduler.initialize(backend)
- scheduler
--- End diff --
@tgravescs sorry, I see what you mean now. Still, I see this as an
improvement; the `scheduler` variables in all the cases are not used anywhere -
in fact, even the `initialize` calls are duplicated in all the different cases.
So unless there is a real desire to be able to match backends and
schedulers at will, I think encapsulating the backend initialization like I did
is a better pattern.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
