Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13057#discussion_r64039329
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala ---
@@ -415,14 +422,16 @@ object YarnSparkHadoopUtil {
* the behavior of '%' in a .cmd file: it gets interpreted as an
incomplete environment
* variable. Windows .cmd files escape a '%' by '%%'. Thus, the correct
way of writing
* '%%p' in an escaped way is '%%%%p'.
- *
- * @return The correct OOM Error handler JVM option, platform dependent.
*/
- def getOutOfMemoryErrorArgument: String = {
+ private[yarn] def addOutOfMemoryErrorArgument(javaOpts:
ListBuffer[String]): Unit = {
if (Utils.isWindows) {
- escapeForShell("-XX:OnOutOfMemoryError=taskkill /F /PID %%%%p")
+ if (!javaOpts.exists(_.contains("-XX:OnOutOfMemoryError"))) {
--- End diff --
OK, but this duplicates the condition. You probably want to flip the
nesting of the if conditions here to avoid it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
