Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/13231#issuecomment-220754628
This looks good at high level. I'd separate the bug fix from the feature
improvement and submit a pr for the bug fix with a test case. We should merge
that bug fix into 2.0.
The feature improvement should probably go into 2.1. In the future we can
also introduce a merge sort operator that combines the multiple files in a
single partition and then perform merge join without the extra full sort.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
