Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8559#discussion_r64228655
  
    --- Diff: 
core/src/test/resources/META-INF/services/org.apache.spark.scheduler.ExternalClusterManager
 ---
    @@ -1 +1,2 @@
    -org.apache.spark.scheduler.DummyExternalClusterManager
    \ No newline at end of file
    +org.apache.spark.scheduler.DummyExternalClusterManager
    +org.apache.spark.scheduler.MockExternalClusterManager
    --- End diff --
    
    I did not, mostly because I thought Dummy should be left as is, to keep 
ExternalClusterManagerSuite cleanly focused.  It would be easy to combine them, 
though.  Dummy isn't covering any cases that Mock isn't -- I could remove 
Dummy, and make ExternalClusterManagerSuite reference Mock, without making any 
changes to Mock.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to