Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/1751#issuecomment-51276904
  
    The problem is that the test suite uses zookeeper classes, but does not 
depend on the zookeeper artifact. The most direct fix is to introduce a test 
dependency on org.apache.zookeeper:zookeeper, I believe, which is already 
configured in the parent?
    
    How does it work with SBT? Well, zookeeper is a transitive dependency of 
Kafka, and Kafka is a non-test dependency of this module. SBT includes it, 
perhaps. I know Maven, weirdly, does *not* include transitive dependencies of 
test dependencies for some reason.
    
    In fact spark-core uses zookeeper too and doesn't express the dependency. 
It's also getting away with it because Curator depends on Zookeeper. That's 
kind of OK since Curator is a ZK utility of sorts. But not technically right, 
and means that the ZK version in the build is not actually controlled by its 
zookeeper.properties value. (It's unused.)
    
    I'll make a PR tomorrow if nobody has patched it already. It'd be good to 
get both of those corrected, but the immediate issue is the test compilation 
issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to