Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13212#discussion_r64266371
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -774,13 +774,42 @@ class SparkSqlAstBuilder(conf: SQLConf) extends
AstBuilder {
}
/**
- * Create an [[AddJarCommand]] or [[AddFileCommand]] command depending
on the requested resource.
+ * Create a [[AddFileCommand]], [[AddJarCommand]], [[ListFilesCommand]]
or [[ListJarsCommand]]
+ * command depending on the requested operation on resources.
+ * Expected format:
+ * {{{
+ * ADD (FILE[s] [filepath ...] | JAR[s] [jarpath ...])
+ * DELETE (FILE[s] [filepath ...] | JAR[s] [jarpath ...])
+ * LIST (FILE[s] [filepath ...] | JAR[s] [jarpath ...])
+ * }}}
*/
- override def visitAddResource(ctx: AddResourceContext): LogicalPlan =
withOrigin(ctx) {
- ctx.identifier.getText.toLowerCase match {
- case "file" => AddFileCommand(remainder(ctx.identifier).trim)
- case "jar" => AddJarCommand(remainder(ctx.identifier).trim)
- case other => throw operationNotAllowed(s"ADD with resource type
'$other'", ctx)
+ override def visitManageResource(ctx: ManageResourceContext):
LogicalPlan = withOrigin(ctx) {
+ val mayebePaths = remainder(ctx.identifier).trim
+ ctx.op.getType match {
+ case SqlBaseParser.ADD =>
+ ctx.identifier.getText.toLowerCase match {
+ case "file" => AddFileCommand(mayebePaths)
+ case "jar" => AddJarCommand(mayebePaths)
+ case other => throw operationNotAllowed(s"ADD with resource type
'$other'", ctx)
+ }
+ case SqlBaseParser.DELETE =>
+ throw operationNotAllowed(s"DELETE resources", ctx)
+ case SqlBaseParser.LIST =>
+ ctx.identifier.getText.toLowerCase match {
+ case "files" | "file" =>
+ if (mayebePaths.length > 0) {
+ ListFilesCommand(mayebePaths.split("\\s+"))
--- End diff --
I also just confirmed that Hive shell behaves the similarly.
```
hive> add jar 'file:/test/test 1.jar';
Illegal character in scheme name at index 0: 'file:/test/test
Query returned non-zero code: 1, cause: java.net.URISyntaxException:
Illegal character in scheme name at index 0: 'file:/test/test
hive>
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
