Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/13247#issuecomment-221173676
Initially, I did try to do it in that way. The questions bothering me are
how to know which changes are made at runtime? which changes are from external
users?
After reading the code base, based on my understanding, we will not
externalize `SQLConf` after introducing `RumtimeConfig`. The `set` APIs of
`SQLConf` will be for internal usage only? Thus, we can do whatever we want, if
necessary. For example, to verify the internal behaviors, our test suites are
still allowed to change the configuration at runtime. For example, in multiple
test cases, like
[ddlsuite](https://github.com/apache/spark/blob/5afd927a47aa7ede3039234f2f7262e2247aa2ae/sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala#L129),
we change `spark.sql.warehouse.dir` at runtime.
Then, I am wondering if we just need to block the changes on the static
configuration properties through `RuntimeConfig`? That is the reason why this
PR is to remove the `conf` from `SQLContext`.
Feel free to let me know which ways are preferred. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
