Github user dominik-jastrzebski commented on the pull request:
https://github.com/apache/spark/pull/12895#issuecomment-221195720
I discovered that `impurity` and `lossType` validators in several places
perform a case-insensitive comparison, for example: `(value: String) =>
GBTRegressorParams.supportedLossTypes.contains(value.toLowerCase)`.
Probably it's the reason why ParamValidators aren't used here. Maybe we
should introduce something like `ParamValidators.inArray(expected:
Array[String], caseInsensitive: Boolean = false)`?
Beside that, I didn't find any missing or incorrect validators.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
