Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/13192#discussion_r64446968
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeFormatterSuite.scala
---
@@ -36,6 +36,22 @@ class CodeFormatterSuite extends SparkFunSuite {
}
}
+ test("removing overlapping comments") {
+ val code = new CodeAndComment(
+ """/*project_c4*/
+ |/*project_c3*/
+ |/*project_c2*/
+ """.stripMargin,
+ Map(
+ "/*project_c4*/" -> "// (((input[0, bigint, false] + 1) + 2) +
3))",
--- End diff --
Hi, @cloud-fan .
This is only targeting for those overlapping expressions.
It's not for multi-line comments.
Could you give me some kind of `generated overlapping multi-line comment`?
If then, I can grasp your concerns more fast.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
