Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13286#discussion_r64494863
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/ContinuousQueryManager.scala ---
    @@ -175,9 +175,9 @@ class ContinuousQueryManager(sparkSession: 
SparkSession) {
           checkpointLocation: String,
           df: DataFrame,
           sink: Sink,
    +      outputMode: OutputMode,
           trigger: Trigger = ProcessingTime(0),
    -      triggerClock: Clock = new SystemClock(),
    -      outputMode: OutputMode = Append): ContinuousQuery = {
    +      triggerClock: Clock = new SystemClock()): ContinuousQuery = {
    --- End diff --
    
    I just realized we should make the constructor of `ContinuousQueryManager` 
be `private[sql]` since we don't want people to call it. Could you also fix it 
in this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to