Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13286#discussion_r64498668
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/OutputMode.java 
---
    @@ -15,9 +15,10 @@
      * limitations under the License.
      */
     
    -package org.apache.spark.sql.catalyst.analysis
    +package org.apache.spark.sql;
     
    -sealed trait OutputMode
    -
    -case object Append extends OutputMode
    -case object Update extends OutputMode
    +public enum OutputMode {
    +  Append,
    +  Update,
    --- End diff --
    
    This actually raises a good question.  I'm not sure if we can use enums 
here as I think that we need to have a notion of a `key` in order to do an 
`Update` mode.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to