Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13286#discussion_r64796991
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulAggregate.scala
 ---
    @@ -82,40 +82,62 @@ case class StateStoreRestoreExec(
     case class StateStoreSaveExec(
         keyExpressions: Seq[Attribute],
         stateId: Option[OperatorStateId],
    +    returnAllStates: Option[Boolean],
    --- End diff --
    
    Similar to stateId, it is injected later after creation of the physical 
Spark plan, and before execution. See IncrementalExecution, and how stateId is 
injected using the prepare rule. 
    
    I agree that this structure is something we can improve, but that would 
require quite a bit of refactoring and better done later. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to