GitHub user srowen opened a pull request:

    https://github.com/apache/spark/pull/1804

    SPARK-1022 [BUILD] Depend on Zookeeper from Kafka tests

    Per discussion at https://github.com/apache/spark/pull/1751 I suggest that 
the more correct thing to do is to depend on Zookeeper from Kafka tests. The 
first commit does this.
    
    The second commit reflects the explicit dependency on ZK in core, in order 
to make `zookeeper.version` do something. Another reasonable change would be to 
simply remove `zookeeper.version` to reflect that otherwise it does nothing.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srowen/spark SPARK-1022

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/1804.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1804
    
----
commit 109f80e23d2f9909afe57b8598f7cef9c0f6c310
Author: Sean Owen <[email protected]>
Date:   2014-08-06T08:21:14Z

    Directly depend on zookeeper in external/kafka tests, because tests use ZK 
directly

commit 4cbd04d62eb5e93cab9a237aea7209b66b67b4be
Author: Sean Owen <[email protected]>
Date:   2014-08-06T08:22:01Z

    Depend on ZK directly, with Curator, to pull in version specified by 
zookeeper.version

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to