Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13271#discussion_r64841022
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -419,35 +426,77 @@ abstract class TreeNode[BaseType <:
TreeNode[BaseType]] extends Product {
*/
def nodeName: String = getClass.getSimpleName.replaceAll("Exec$", "")
+ /** The argument list to be displayed in tree String. */
+ protected def argumentsForStringOutput(verbose: Boolean): Seq[(String,
Any)] = {
--- End diff --
do we really need this? I understand you are trying to make it very
general, but the number of operators that are replacing this seems small.
The ones that want to override this can also just override simpleString.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
