Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/13318#discussion_r64842068
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/ShuffleInMemorySorter.java ---
@@ -54,14 +54,14 @@ public int compare(PackedRecordPointer left,
PackedRecordPointer right) {
private final boolean useRadixSort;
/**
- * Set to 2x for radix sort to reserve extra memory for sorting,
otherwise 1x.
+ * The position in the pointer array where new records can be inserted.
*/
- private final int memoryAllocationFactor;
+ private int pos = 0;
/**
- * The position in the pointer array where new records can be inserted.
+ * How many records could be inserted, because part of the array should
be left for sorting.
*/
- private int pos = 0;
+ private int capacity = 0;
--- End diff --
nit: usableCapacity?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
