Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/13342#discussion_r64844881
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -358,6 +360,35 @@ final class DataFrameWriter private[sql](df:
DataFrame) {
}
/**
+ * :: Experimental ::
+ * Starts the execution of the streaming query, which will continually
send results to the given
+ * [[ForeachWriter]] as new data arrives. The returned
[[ContinuousQuery]] object can be used to
+ * interact with the stream.
+ *
+ * @since 2.0.0
+ */
+ @Experimental
+ def foreach(writer: ForeachWriter[T]): ContinuousQuery = {
+ val queryName = extraOptions.getOrElse("queryName",
StreamExecution.nextName)
+ val checkpointLocation = extraOptions.get("checkpointLocation")
+ .orElse {
+ df.sparkSession.sessionState.conf.checkpointLocation.map { l =>
+ new Path(l, queryName).toUri.toString
+ }
+ }.getOrElse {
--- End diff --
I think similar to memorysink, the user should not have to specify
checkpoint location.
Also could you consolidate the code for finding checkpoint location across
memory sink, file sink and foreach sink.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
