Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13342#discussion_r64846038
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
    @@ -156,7 +156,7 @@ private[sql] object Dataset {
     class Dataset[T] private[sql](
         @transient val sparkSession: SparkSession,
         @DeveloperApi @transient val queryExecution: QueryExecution,
    -    encoder: Encoder[T])
    +    private[sql] val encoder: Encoder[T])
    --- End diff --
    
    should we use unresolvedTEncoder or resolvedTEncoder? @marmbrus mentioned 
in the past that we should probably get rid of some of these to make it more 
obvious what to use.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to