Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13321#discussion_r64869945
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
    @@ -336,9 +336,11 @@ private[sql] object DataSourceScanExec {
       def create(
           output: Seq[Attribute],
           rdd: RDD[InternalRow],
    -      relation: BaseRelation,
    +      logicalRelation: LogicalRelation,
           metadata: Map[String, String] = Map.empty,
           metastoreTableIdentifier: Option[TableIdentifier] = None): 
DataSourceScanExec = {
    +    val relation: BaseRelation = logicalRelation.relation
    +
         val outputPartitioning = {
           val bucketSpec = relation match {
    --- End diff --
    
    yea it's suboptimal, we should think harder about when should we disable 
bucketing. But for this PR, we are trying to fix a bug, improving bucketing is 
another story, we can do it after this PR. What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to