GitHub user zhengruifeng opened a pull request:

    https://github.com/apache/spark/pull/13356

    [SPARK-15610][ML] PCA should not support k == numFeatures

    ## What changes were proposed in this pull request?
    Fix the wrong bound of `k` in `PCA`
    `require(k <= sources.first().size, ...`  ->  `require(k < 
sources.first().size`
    
    BTW, remove unused import in `ml.ElementwiseProduct`
    
    ## How was this patch tested?
    
    manual tests
    
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhengruifeng/spark fix_pca

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/13356.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13356
    
----
commit e886e6e837aeb56a410621ed2ffa06bcaebabd35
Author: Zheng RuiFeng <ruife...@foxmail.com>
Date:   2016-05-27T09:52:52Z

    create pr

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to