Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13351#discussion_r64899457
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2345,17 +2345,19 @@ private[spark] class RedirectThread(
*/
private[spark] class CircularBuffer(sizeInBytes: Int = 10240) extends
java.io.OutputStream {
var pos: Int = 0
+ var isBufferFull = false
var buffer = new Array[Int](sizeInBytes)
--- End diff --
I think we have more problems with this class. This should be `val buffer =
new Array[Byte](sizeInBytes)`. It's 4x larger than it needs to be.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
