Github user JoshRosen commented on the pull request:

    https://github.com/apache/spark/pull/1758#issuecomment-51375435
  
    This PR is now failing ConnectionManagerSuite's "security on same password" 
test; the remote connection manager is throwing this exception:
    
    ```java
    Exception in thread "handle-message-executor-0" java.lang.Error: 
java.io.IOException: Error evaluating sasl response:
        at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1151)
        at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
        at java.lang.Thread.run(Thread.java:745)
    Caused by: java.io.IOException: Error evaluating sasl response:
        at 
org.apache.spark.network.ConnectionManager.handleClientAuthentication(ConnectionManager.scala:551)
        at 
org.apache.spark.network.ConnectionManager.handleAuthentication(ConnectionManager.scala:610)
        at 
org.apache.spark.network.ConnectionManager.org$apache$spark$network$ConnectionManager$$handleMessage(ConnectionManager.scala:639)
        at 
org.apache.spark.network.ConnectionManager$$anon$9.run(ConnectionManager.scala:511)
        at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
        ... 2 more
    Caused by: javax.security.sasl.SaslException: DIGEST-MD5: Digest-challenge 
format violation: algorithm directive missing
        at 
com.sun.security.sasl.digest.DigestMD5Client.processChallenge(DigestMD5Client.java:296)
        at 
com.sun.security.sasl.digest.DigestMD5Client.evaluateChallenge(DigestMD5Client.java:225)
        at 
org.apache.spark.SparkSaslClient.saslResponse(SparkSaslClient.scala:83)
        at 
org.apache.spark.network.ConnectionManager.handleClientAuthentication(ConnectionManager.scala:533)
        ... 6 more
    ```
    
    It appears that `evaluateChallenge` is being called with a zero-length byte 
array and I don't think that DIGEST-MD5 supports this.  I'm not sure what's 
causing this to happen, since the error doesn't occur at commit 
ee91bb793666b260c9018e532dcf32c7115b3194.  Because that earlier commit passes 
fine, I don't think the changes to MessageChunkHeader are corrupting the actual 
bytes that we're sending (I verified this with additional logging statements).  
I think I might be exposing a race condition somewhere, since small 
permutations of the current code seem to pass.
    
    @tgravescs, do you have any thoughts on what could be causing this error?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to