Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13321#discussion_r64944786
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -347,15 +347,16 @@ private[sql] object DataSourceScanExec {
case _ => None
}
- def toAttribute(colName: String): Attribute = output.find(_.name ==
colName).getOrElse {
- throw new AnalysisException(s"bucket column $colName not found in
existing columns " +
- s"(${output.map(_.name).mkString(", ")})")
- }
+ def toAttribute(colName: String): Attribute = output.find(_.name ==
colName).get
bucketSpec.map { spec =>
val numBuckets = spec.numBuckets
- val bucketColumns = spec.bucketColumnNames.map(toAttribute)
- HashPartitioning(bucketColumns, numBuckets)
+ if (spec.bucketColumnNames.forall(colName => output.exists(_.name
== colName))) {
+ val bucketColumns = spec.bucketColumnNames.map(toAttribute)
--- End diff --
this is OK, but I think a better way to write this is
```
val bucketColumns = output.filter { a =>
spec.bucketColumnNames.contains(a.name) }
if (bucketColumns.size == spec.bucketColumnNames.size) {
HashPartitioning(bucketColumns, numBuckets)
}
```
then you don't need `toAttribute`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
