Github user nchammas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1744#discussion_r15892897
  
    --- Diff: python/pyspark/tests.py ---
    @@ -622,14 +624,15 @@ def test_newhadoop(self):
                 
valueConverter="org.apache.spark.api.python.WritableToDoubleArrayConverter").collect())
             self.assertEqual(result, array_data)
     
    -        conf = {"mapreduce.outputformat.class" :
    -                     
"org.apache.hadoop.mapreduce.lib.output.SequenceFileOutputFormat",
    -                 "mapred.output.key.class" : 
"org.apache.hadoop.io.IntWritable",
    -                 "mapred.output.value.class" : 
"org.apache.spark.api.python.DoubleArrayWritable",
    -                 "mapred.output.dir" : basepath + "/newdataset/"}
    -        self.sc.parallelize(array_data).saveAsNewAPIHadoopDataset(conf,
    +        conf = {"mapreduce.outputformat.class":
    +                
"org.apache.hadoop.mapreduce.lib.output.SequenceFileOutputFormat",
    +                "mapred.output.key.class": 
"org.apache.hadoop.io.IntWritable",
    +                "mapred.output.value.class": 
"org.apache.spark.api.python.DoubleArrayWritable",
    +                "mapred.output.dir": basepath + "/newdataset/"}
    --- End diff --
    
    I'll fix this to follow the style you specified, but note that the first 
pair in the `dict` is longer than 100 characters so it will have to be broken 
up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to