GitHub user yhuai opened a pull request:

    https://github.com/apache/spark/pull/13366

    [SPARK-15622] [SQL] Wrap the parent classloader of Janino's classloader in 
the ParentClassLoader.

    ## What changes were proposed in this pull request?
    At 
https://github.com/aunkrig/janino/blob/janino_2.7.8/janino/src/org/codehaus/janino/ClassLoaderIClassLoader.java#L80-L85,
 Janino's classloader throws the exception when its parent throws a 
ClassNotFoundException with a cause set. However, it does not throw the 
exception when there is no cause set. Seems we need to use a special 
ClassLoader to wrap the actual parent classloader set to Janino handle this 
behavior.
    
    ## How was this patch tested?
    I have reverted the workaround made by 
https://issues.apache.org/jira/browse/SPARK-11636 ( 
https://github.com/apache/spark/compare/master...yhuai:SPARK-15622?expand=1#diff-bb538fda94224dd0af01d0fd7e1b4ea0R81)
 and `test-only *ReplSuite -- -z "SPARK-2576 importing implicits"` still passes 
the test (without the change in `CodeGenerator`, this test does not pass with 
the change in `ExecutorClassLoader `).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yhuai/spark SPARK-15622

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/13366.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13366
    
----
commit a539fae1e2b0928e98c2f338ff3376c8c7f8fe18
Author: Yin Huai <[email protected]>
Date:   2016-05-27T22:12:54Z

    [SPARK-15622] [SQL] Wrap the parent classloader of Janino's classloader in 
the ParentClassLoader.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to