Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13363#discussion_r64974333
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -424,23 +424,50 @@ abstract class TreeNode[BaseType <:
TreeNode[BaseType]] extends Product {
*/
protected def stringArgs: Iterator[Any] = productIterator
- /** Returns a string representing the arguments to this node, minus any
children */
- def argString: String = productIterator.flatMap {
- case tn: TreeNode[_] if containsChild(tn) => Nil
- case tn: TreeNode[_] => s"${tn.simpleString}" :: Nil
- case seq: Seq[BaseType] if seq.toSet.subsetOf(children.toSet) => Nil
- case seq: Seq[_] => seq.mkString("[", ",", "]") :: Nil
- case set: Set[_] => set.mkString("{", ",", "}") :: Nil
- case other => other :: Nil
- }.mkString(", ")
-
- /** String representation of this node without any children. */
- def simpleString: String = s"$nodeName $argString".trim
+ /**
+ * Returns a string representing the arguments to this node
+ *
+ * @param verbose Controls whether to output more verbose string or not.
+ */
+ def argString(verbose: Boolean): String = {
+ productIterator.flatMap {
+ case tn: TreeNode[_] if containsChild(tn) => Nil
+ case tn: TreeNode[_] => s"${if (verbose) tn.verboseString else
tn.simpleString}" :: Nil
--- End diff --
Nit: You can simply move the `if` expression out of `s"..."`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
