Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13363#discussion_r64975446
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregate.scala
---
@@ -760,16 +760,29 @@ case class TungstenAggregate(
}
override def simpleString: String = {
+ toString(verbose = false)
+ }
+
+ override def verboseString: String = {
+ toString(verbose = true)
+ }
+
+ private def toString(verbose: Boolean): String = {
val allAggregateExpressions = aggregateExpressions
testFallbackStartsAt match {
case None =>
val keyString = groupingExpressions.mkString("[", ",", "]")
val functionString = allAggregateExpressions.mkString("[", ",",
"]")
val outputString = output.mkString("[", ",", "]")
- s"TungstenAggregate(key=$keyString, functions=$functionString,
output=$outputString)"
+
+ if (verbose) {
+ s"Aggregate(key=$keyString, functions=$functionString,
output=$outputString)"
+ } else {
+ s"Aggregate(key=$keyString, functions=$functionString)"
+ }
case Some(fallbackStartsAt) =>
- s"TungstenAggregateWithControlledFallback $groupingExpressions " +
+ s"AggregateWithControlledFallback $groupingExpressions " +
--- End diff --
Not quite sure about this one, but is this change intentional?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
