Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13367#discussion_r64979349
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -126,7 +137,9 @@ private[sql] case class AggregateExpression(
AttributeSet(childReferences)
}
- override def toString: String =
s"($aggregateFunction,mode=$mode,isDistinct=$isDistinct)"
+ override def toString: String = {
+ mode.prefix + aggregateFunction.toAggString(isDistinct)
--- End diff --
I'm wondering if it's clearer to do a pattern match here to get the prefix
of mode, instead of adding the `prefix` method?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
