Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/13372#issuecomment-222316908
This is the meaningful suggestion. I think all the option validation should
be done in a single place and, if there is an invalidate option, spark should
throw clear messages for making users easily understood.
As for `samplingRatio`, should we check the validation not in
`inferSchema`, but `JSONOptions? This is because, for example, the validation
of `parseMode` is done there. I think we'd be better of finishing these
validation in `JSONOptions` and CSVOptions`.
Anyway, I'm not sure these fixes should be included in this pr and
follow-up prs seems to be okay to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
